This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Enable float32 data type in linalg cholesky test#20508
Open
mozga-intel wants to merge 7 commits intoapache:masterfrom
Open
Enable float32 data type in linalg cholesky test#20508mozga-intel wants to merge 7 commits intoapache:masterfrom
mozga-intel wants to merge 7 commits intoapache:masterfrom
Conversation
|
Hey @mozga-intel , Thanks for submitting the PR
CI supported jobs: [website, clang, sanity, unix-cpu, centos-cpu, miscellaneous, windows-gpu, edge, centos-gpu, windows-cpu, unix-gpu] Note: |
6 tasks
…cholesky_float32_support_enable
Contributor
Author
|
@mxnet-bot run ci [all] |
|
Jenkins CI successfully triggered : [clang, unix-gpu, unix-cpu, centos-gpu, website, windows-cpu, edge, centos-cpu, windows-gpu, sanity, miscellaneous] |
Member
|
Looks like the atol and rtol need to be adjusted for lower precision cholesky op. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regarding #20505 . The Cholesky test on the current master uses only float64 data type. Checking Float32 data type is disabled. Is this intended or negligence? Here is a quick fix to check on float32 data type.
Checklist
Essentials
Changes
Comments