-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: pass pre-read content to RegistryClient for WSL compatibility #9739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: pass pre-read content to RegistryClient for WSL compatibility #9739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 18 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="core/llm/index.ts">
<violation number="1" location="core/llm/index.ts:1124">
P2: Tool prompt overrides are skipped when tools are only defined in the model’s default completionOptions, so per-model overrides never apply to default tools.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
36b953b to
75d9d05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shanevcantwell to clarify, is there a case where it loads content from not a file or slug? I'm thinking that we could just add the content field and check if it's present rather than adding a new uriType. This would simplify the PR significantly e.g. getContent could just check if content is present and if so return it, and most other changes could be reverted.
I would also be able to merge this faster since we use this type on our backend (and other people might too) and adding a new uriType could be a breaking change
Fixes continuedev#6242, continuedev#7810 When Windows VS Code connects to WSL, workspace files are accessed via vscode-remote:// URIs. Previously, getAllDotContinueDefinitionFiles() correctly read content via ide.readFile(), but loadYaml.ts discarded the content and passed only the URI path to RegistryClient, which then tried to re-read using fs.readFileSync() - failing for remote URIs. Changes: - Add optional content field to FileIdentifier (non-breaking) - RegistryClient.getContent() returns pre-read content when present - loadYaml.ts passes content along with file identifiers Co-Authored-By: Claude Opus 4.5 <[email protected]>
a9a9ebb to
1c74659
Compare
That was definitely an excessive solution. This is much cleaner. |
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean!
Summary
.continue/files failing to load when Windows VS Code connects to WSLloadYaml.tsdiscarded pre-read content and passed only URIs toRegistryClient, which triedfs.readFileSync()(fails forvscode-remote://URIs)ContentIdentifiertype to pass pre-read content directly through the loading pipelineFixes #6242, Fixes #7810
Test plan
code --install-extension.continue/docs/test.yamlin WSL workspace🤖 Generated with Claude Code
Continue Tasks
Powered by Continue
Summary by cubic
Fixes WSL config loading by passing pre-read YAML content through the pipeline to avoid fs reads on vscode-remote:// URIs (Fixes #6242, #7810).
Written for commit 1c74659. Summary will update on new commits.