feat: add code lens in sticky scroll widget#182950
feat: add code lens in sticky scroll widget#182950harbin1053020115 wants to merge 14 commits intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree company="alibaba" |
|
Feature as:
|
| codeLensCont.style.cssText = `position: relative; left: ${layoutInfo.contentLeft}px;`; | ||
| child.appendChild(codeLensCont); | ||
|
|
||
| // Convert codelens startColumn to space and use renderViewLine to render it |
There was a problem hiding this comment.
@aiday-mar Is there a better way to compute the Code Lens's marginLeft?
There was a problem hiding this comment.
As now I use renderViewLine to render spaces(according to the startColumn) before the Code Lens, which I think is not a lightweight solution.
There was a problem hiding this comment.
@VSCodeTriageBot Any one can handle this pull request?
There was a problem hiding this comment.
@harbin1053020115 the team are in the middle of endgame, so I don't think this PR will get looked at until afterwards.
There was a problem hiding this comment.
@harbin1053020115 the team are in the middle of endgame, so I don't think this PR will get looked at until afterwards.
@gjsjohnmurray You mean May 2023 Endgame(https://github.com/microsoft/vscode/issues/183504)？
|
Hi @harbin1053020115 great work here! Unfortunately we can not merge this because we are planning in the future to introduce a generic framework to add all kinds of decoration : highlight colors, code lens, indentation lines. We need to create a general piece of code that covers all the editor decorations and code lens decorations would use this code. It is unclear as of yet when we will work on this, but it is on the roadmap. |
That's great, the sticky widget now has some style problems also. |
4 participants
Issue: #182949