Fix #207977, multieditor tab border offset position when activated#207980
Closed
yiliang114 wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix #207977, multieditor tab border offset position when activated#207980yiliang114 wants to merge 1 commit intomicrosoft:mainfrom
yiliang114 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
yiliang114
commented
Mar 18, 2024
yiliang114
commented
Contributor
|
@yiliang114 The fix required for this issue is a bit more complicated and probably needs to be done on the level of the split view to move the entire view out of the border but we would also have to let the computation of the view sizes know they have 1px less to use. Vertical split views would also have to be considered. I'm closing this PR as it's not the right approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
