add custom attribute support for preload/prefetch#53
Closed
moyus wants to merge 1 commit intonumical:masterfrom
Closed
add custom attribute support for preload/prefetch#53moyus wants to merge 1 commit intonumical:masterfrom
moyus wants to merge 1 commit intonumical:masterfrom
Conversation
Owner
|
I can see this being useful. |
This was referenced Oct 29, 2018
Owner
|
Hi, |
Author
|
Seems great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When maintain a large web application, we need to deploy static assets on CDN, which has a different origin against our web domain. So in order to use tools like sentry to track js errors, we need to add
crossorigin="anonymous"attribute on scripts.However, when use preload/prefetch feature of script-ext-html-webpack-plugin, the output
<link />don't containcrossorigin="anonymous", which will cause double fetches.This PR is try to add a feature to support custom attributes for link tag.
example: