Feature/attachment improvements #833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
Add newline at end of file.
phpBB/posting.php
Outdated
Contributor
There was a problem hiding this comment.
Please put comments on their own line.
phpBB/includes/functions_upload.php
Outdated
Collaborator
There was a problem hiding this comment.
Add an empty line after this one.
Collaborator
|
Hmm, ideally |
Escape the extensions string provided to the plupload object PHPBB3-10929
…on strings PHPBB3-10929
…_FILES PHPBB3-10929
…pload PHPBB3-11190
Collaborator
There was a problem hiding this comment.
You will have to amend the commit that makes this changes to not make them.
Contributor
|
@Fyorl Status? |
|
Am I missing something, cannot see anything changed in posting_attach_body.html template ? |
Contributor
|
No commits in a year, closing due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=42727
Ticket: http://tracker.phpbb.com/browse/PHPBB3-10929
Integration of plupload with the current attachment system. This feature will also include some work to implement a 'download all attachments' for each post or topic.