WIP: [feature/auth refactoring] Authentication Plugin Refactoring and User Integration #836
Conversation
phpBB/check_auth_openid.php
Outdated
phpBB/composer.lock
Outdated
There was a problem hiding this comment.
Not sure, that is a generated file. I didn't modify anything related to symfony.
…tion More changes related to testing authentication. PHPBB3-9734
Fixes sesion_testable_factory to properly use the extension finder to find the providers that are installed. PHPBB3-9734
Fixes a few small errors in abstract provider and the native_test. Sets the framework for the OpenID unit test. PHPBB3-9734
Removes a variable passed by reference. PHPBB3-9734
Brings us up to ZF2-rc3. PHPBB3-9734
Mocks the functionality of Enable and Disable super globals. PHPBB3-9734
Fixes several issues with the native_test in auth/provider. PHPBB3-9734
The test still doesn't work on my computer. But it gets significantly further than before. PHPBB3-9734
Moves test data from tests/auth/provider/ to tests/auth/provider/fixtures to maintain consistency. PHPBB3-9734
|
@Hardolaf What's the status of this? Still WIP? |
|
@EXreaction This is still WIP. I had hoped to get work done on it but my college schedule hasn't been conducive to working on anything. I think I might have some time over spring break, but I can't guarantee anything. Most of the work that needs to be done is rebasing it onto develop and finishing the unit tests. I hadn't finished this to be pushed out because of a strange error that I was unable to figure out being caused by the database while writing the unit tests. If I can get past that point, it should be trivial to get ready for merging. |
|
@Hardolaf Would you be able to rebase on or merge the latest develop? If you can do that I might be able to help you with the error. |
|
@EXreaction I'll see if I can get it rebased by the end of this Sunday. I'll probably start Saturday afternoon as I have classes through Friday. |
There was a problem hiding this comment.
Might be more readable if you use jQuery; Sizzle has an optimisation which means that IDs are called using document.getElementById anyway, so it is no slower.
There was a problem hiding this comment.
I'll look into which is more readable this week.
|
@Hardolaf will you be rebasing this PR or creating a new one (using some code snippets/ commits from this one) ? |
|
Looks like https://github.com/Hardolaf/phpbb3/compare/feature;auth-refactor is the branch he will be using. I assume he will create a Pull Request from it when he is ready for comments. For now I'll go ahead and close this. It can be re-opened if needed. |
8 participants
RFC: http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=42895
Ticket: http://tracker.phpbb.com/browse/PHPBB3-9734
Refactoring of existing authentication code to separate it out into gui and backend code instead of leaving it integrated. Add support for logging in with and registering with third party services such as Facebook and OpenID.