Change read_tmy3 parameter input order#1791
Closed
AdamRJensen wants to merge 1 commit intopvlib:mainfrom
Closed
Conversation
7 tasks
Member
|
I think it might make sense for technical mumbo-jumbo parameters like |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remote-data) and Milestone are assigned to the Pull Request and linked Issue.Based on this #1779 (comment), it seems there is consensus that the
map_variableparameter should be the last or second to last input parameters. This PR updates this for theread_tmy3function (variable mapping ofread_tmy3has yet to be officially released, hence this PR is not a breaking change).