-
Notifications
You must be signed in to change notification settings - Fork 384
Coveralls.io #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coveralls.io #144
Conversation
|
Thanks, have been meaning to poke more at coverage and linting. Will see if I can get to this sometime soon. |
5f10eb9 to
3b0ad03
Compare
Remove this commit when pyinvoke/invocations#5 is merged
3b0ad03 to
0bef2e0
Compare
|
@bitprophet ping |
|
I'd (humbly) offer checking out codecov.io. It will report on how a particular PR is covered, in addition to what coveralls does, which is report on how the PR affects coverage. I'm much less interested in (+0.02% coverage) than I am (This PR is 48% covered). |
|
a) I've been poking more at vanilla coverage.py lately and it is real nice, so this topic is on my mind (also commented on the invocations PR, since I accidentally wrote my own coverage method) |
|
Double checked the current state of features for coveralls.io vs codecov and from their websites at least, codecov does still look more useful, coveralls continues to have the "+N% coverage" focus which is less useful. Will test out actually using codecov and if I like how it looks, will add that to travis. |
|
Hrm, don't see any way to tell codecov to give flags to the report generation; currently my coverage stuff has to tell Similarly I don't see a way to give this info to coveralls.io. Digging further to see why I opted to do the filtering at html-generation time, maybe I'll get lucky and there's a way to do it at coverage-generation time instead. Otherwise this will be kind of a no-op and I'll just have to jury-rig something stupid like "generate coverage report, then inspect it for the coverage percentage". |
|
Sweet, apparently at the time I was ignorant of the use of |
|
Test upload seems to work reasonably well: https://codecov.io/github/pyinvoke/invoke?ref=07a956e789c25b721bd08442624b60c70efd47a8 It's like 0.5% less coverage than native The 1/2-ness is constant across all covered files, which is...pretty bizarre. Can't find much online about this besides a probably-not-related twitter convo: https://twitter.com/glenathan/status/603883608651264000 That said, when it represents such a small amount-of-coverage for now, and only seems to affect branch coverage which is itself always a dicey proposition, Good Enough For Now. |
|
Glad to hear that. The founder there is pretty responsive, in my On Monday, December 21, 2015, Jeff Forcier [email protected] wrote:
Sent via mobile phone. |
|
Good to know, thanks again @justinabrahms! Re: other bits in this PR, codecov's equivalent status badge can be found on https://codecov.io/github/pyinvoke/invoke/features/badges so I'll work that in, and then preserve the Travis status badge too cuz why not :) EDIT: oh right, that stuff's in our website sidebar, so having it in the README is kind of meh. May take a quick stab at adding it to the sidebar under the Travis hook. |
|
Set CodeCov PR adjusted-line coverage to 90% for now, partly cuz that'd be nice, partly because I assume lots of PRs will fail and I want to see what failure looks like initially :3 |
Measure test coverage, report results to Coveralls, display a badge in the README. Note that this depends on the tests measuring code coverage -- there's a pull request for that here: pyinvoke/invocations#5