Allow subcollections to be defaults of parent collections

[tyewang]

Hi,

I thought it would be a nice for subcollections to be defaults of their parent collection. Given that running a task and running the default task of a subcollection is basically the same (i.e. invoke foo), it makes sense that subcollections can be defaults if tasks can be defaults.

For example, if I have a collection named "tests" with a default task of "run_unit_tests", I might want the default of the top level namespace to be the default of "tests". With this PR, we can do:

tests_collection = Collection('tests')
tests_collection.add_task(Task(run_unit_tests), default=True)

namespace = Collection()
namespace.add_collection(tests_collection, default=True)

That way, I can simply type invoke and run my unit tests.

[bitprophet]

I had to reread your description & glance at the diff to realize that this wasn't duplicating existing functionality. Kind of bizarre that nobody brought this up before, but it makes perfect sense. Thanks!

[tyewang]

Sure, glad to help!

[tyewang]

@bitprophet It says the build failed, but it looks like it passes for Python 3.2. I'm guessing the failures for the other Pythons are unrelated to me. Is there anything I need to do, or are these known issues?

[bitprophet]

Nope that's a known build fail related to an almost-merged branch, sorry. Definitely not your fault. (3.2 works because the part that fails - doc building - is skipped on 3.2 due to dependency issues.)

[tyewang]

Hi @bitprophet, is there anything more I need to do to get this PR merged? What else is it waiting on?

[bitprophet]

Hey @tyewang, sorry for the delay, just been a super busy end/start of year for me :(

This is in the release milestone and I'm picking dev up again very shortly, so this'll get merged pretty soon (you don't need to do anything, I just need to re-test it on my end and make a changelog entry). Thanks for your patience!

[imhotepbot]

• E501 line too long (81 > 79 characters)

[tyewang]

Hey @bitprophet, any update on this PR? It's been 9 months since this has been opened, and it doesn't look like this made it into the 0.11 release. What's up with that?

[bitprophet]

0.11 turned out to just be "a bunch of random stuff that was in master" and I forgot to rename the actual milestone entry; just did. Re: timing, all I can say is sorry, it's volunteer work/time and I have too many projects. I do plan to dig into real release work (as in, merging the stuff in the milestone) in the near future, have been putting time into my own feature dev trying to get an upstream project 2.0 out the door.

[tyewang]

Np, thanks for the update! I just wanted to make sure this PR didn't get forgotten about.

[bitprophet]

Totes, it's in the milestone, so it won't get forgotten, even if the milestone takes a while to get some love. Sorry for confusing you with the surprise 0.11 release!

[tyewang]

@bitprophet any update?

[tyewang]

Hi @bitprophet, any update on this and #246? It's been 13 months since the last update. Anything I can do to help?

[bitprophet]

It's in! Will go out in 1.5. Gonna see how easily I can fold #246 in too...that one's more dicey (looking for easy wins right now). See there for any updates.