-
Notifications
You must be signed in to change notification settings - Fork 384
rough flake8 integration #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dev-requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you stick the latest stable release number in here as an ==? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
Thanks for poking at this! See line comments :) |
|
Also linking to #157 which this kinda supersedes. |
|
Thanks for making those updates. Annoyingly, I didn't notice last time that there's apparently a rule for double spaces before line comments (e.g. Went and checked on all the stuff ignored/not ignored to see if I agree (I'd like to choose a single set of these rule ignores so I can apply them eventually to all of my projects :))...results:
|
8c29dba to
281b22e
Compare
|
Don't worry, I added two space comments in the second change which is why you didn't catch it the first time. :) I originally ignored all of the import cleanup just to keep the diff small enough. Here it is with all of the import cleanup. |
|
Looks good, thanks again! I might tweak that ignores list more in future but this is a great start. |
No description provided.