Port prefix/cd context managers for run/sudo #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
changed the title
bitprophet
reviewed
May 24, 2017
invoke/context.py
Outdated
| For example, one of the most common uses of this tool is with the | ||
| ``workon`` command from `virtualenvwrapper | ||
| <http://www.doughellmann.com/projects/virtualenvwrapper/>`_:: |
Member
There was a problem hiding this comment.
This is now https://virtualenvwrapper.readthedocs.io so we should probs update it!
bitprophet
reviewed
May 24, 2017
| if path.startswith('~') or path.startswith('/'): | ||
| break | ||
|
|
||
| paths = [path.replace(' ', '\ ') for path in self.command_cwds[i:]] |
Member
There was a problem hiding this comment.
Forget offhand but we may want to see if there's a stronger "escape this path" function somewhere we can reuse - think escaping tildes or slashes in filenames and dumb shit like that.
Contributor
Author
|
All passing on CI now. |
Member
|
a) your avatar is hilarious in a Github context, b) haven't forgotten about this! Still doing post-PyCon triage but I have this open in a "deal with it soon" browser tab... 😒 |
Contributor
Author
|
No worries. I'm aware of the very many plates you have 😄 |
This was referenced Jun 2, 2017
Member
|
Also, realized there were two other open tickets about this, that I can now close. Woo! Thanks yet again. |
bitprophet
added a commit
that referenced
this pull request
Jun 5, 2017
As-is, was causing issues in Fabric 2. This should help. Also now documenting the (tweaked) config value that was implicitly used in #446's addition of Context._runner.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.