Update library.rst #469
Merged
Update library.rst #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the instructions it was not obvious how the subclassed config should be added to the program definition. I needed to read the program API to find the relevant information: http://docs.pyinvoke.org/en/latest/api/program.html#module-invoke.program. All examples previous to this section have been accurate and the examples contain all of the relevant information to get the example working.
Member
|
I feel like the "here's specifically how to take your custom Config class and give it to a Program" bit should live in the |
Contributor
Author
|
I agree and started to add it to the note hence the addition of a note segregation. The reason that I opted against it and added it to the example is because the note is outside of the relevant section titled: "Changing filenames and/or env var prefix". It could be possible to just create a note in that section I guess. Happy to help more regarding this if required. |
bitprophet
added a commit
that referenced
this pull request
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the instructions it was not obvious how the subclassed config should be added to the program definition. I needed to read the program API to find the relevant information: http://docs.pyinvoke.org/en/latest/api/program.html#module-invoke.program.
All examples previous to this section have been accurate and the examples contain all of the relevant information to get the example working.