Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds the following API change to the
run()function:This is of course, quite similar to the way
subprocess.Popenandos.execvhandle arguments by default. I think using a list is more convenient when running more complex commands, as you then don't have to worry about construction a safe string to pass to run.Another possibility (that might be taking this a bit too far) is to make
commanda vararg. For example:The
sixversion bump was necessary for thesix.moves.shlex_quotefunction, which is in different places in Py2 and Py3.Kind regards,
Georgi