Skip to content

gh-111062: Separate linux build into a reusable workflow#111446

Closed
NCLI wants to merge 19 commits intopython:mainfrom
NCLI:reusable_ubuntu_build
Closed

gh-111062: Separate linux build into a reusable workflow#111446
NCLI wants to merge 19 commits intopython:mainfrom
NCLI:reusable_ubuntu_build

Conversation

@NCLI
Copy link
Contributor

@NCLI NCLI commented Oct 29, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2023
Closed
@bedevere-app

This comment was marked as resolved.

Sign in to view
dimaqq
dimaqq reviewed Oct 29, 2023
View reviewed changes
.github/workflows/reusable-build-ubuntu.yml Outdated
@@ -0,0 +1,84 @@
name: Tests
Copy link
Contributor

@dimaqq dimaqq Oct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 says remove this name

dimaqq
dimaqq reviewed Oct 29, 2023
View reviewed changes
.github/workflows/reusable-build-ubuntu.yml Outdated
contents: read

jobs:
name: 'Ubuntu reusable'
Copy link
Contributor

@dimaqq dimaqq Oct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 says remove this name

@NCLI NCLI changed the title GH-111062 Reusable ubuntu workflowfor build test GH-111062 Separate linux build into a reusable workflow Oct 29, 2023
dimaqq
dimaqq approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 😄

@NCLI NCLI marked this pull request as ready for review October 29, 2023 07:00
@NCLI NCLI requested a review from ezio-melotti as a code owner October 29, 2023 07:00
@NCLI NCLI requested a review from hugovk as a code owner October 29, 2023 07:00
@dimaqq dimaqq mentioned this pull request Oct 29, 2023
Closed
@hugovk hugovk changed the title GH-111062 Separate linux build into a reusable workflow gh-111062: Separate linux build into a reusable workflow Oct 29, 2023
@hugovk
Copy link
Member

hugovk commented Oct 29, 2023

Looking good, let's first decide on the name, re: #111062 (comment)

reusable-build-ubuntu.yml, or reusable-ubuntu.yml to match reusable-docs.yml?

@corona10
Copy link
Member

corona10 commented Oct 30, 2023

Duplicated with #111452

@corona10 corona10 closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

1 more reviewer

@dimaqq dimaqq dimaqq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hugovk hugovk

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NCLI @hugovk @corona10 @dimaqq