bpo-37223: io.BufferedWrite.close() don't call flush() if already closed#13999
Closed
vstinner wants to merge 2 commits intopython:masterfrom
vstinner:buffered_close
Closed
bpo-37223: io.BufferedWrite.close() don't call flush() if already closed#13999vstinner wants to merge 2 commits intopython:masterfrom vstinner:buffered_close
vstinner wants to merge 2 commits intopython:masterfrom
vstinner:buffered_close
Conversation
Member
Author
|
This PR fix the following 2 errors when running test_io: |
io.BufferedWrite.close() no longer call its flush() method if close() has already been closed. * buffered_close() no longer call buffered_flush() if self->buffer is NULL * _pyio.BufferedWriter.close() now sets _write_buf to None. Moreover, it doesn't call flush() anymore if _write_buf is None. * Add test_flush_error_on_close() to test_io.
Member
Author
|
I rebased my PR, added an unit test and I also fixed the pure Python implementation. |
Add more unit tests
Member
Author
|
This PR changes the behavior of the io module for a corner case. I merged PR #14028 instead to only fix an error when running test_io. IMHO the current behavior makes sense and ensures that text, buffered and fileio states are consistent, especially for the closed attribute. I close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The close() method of io buffered files no longer call flush()
if the file is already closed.
https://bugs.python.org/issue37223