Conversation
Fix building proc-macro crates on musl host when --target is specified.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the PR! I'm not sure that Cargo has a great way to fix this though. Cargo in general doesn't want to configure and/or encode platform-specific settings, but rather provide the knobs for the configuration to be passed down to Cargo. Cargo doesn't have a great way to specify flags for "only host compilations" today, and that's a known bug in Cargo. |
|
I'm going to close this due to inactivity. I think figuring out how to handle proc-macro and musl should be discussed on rust-lang/rust. rust-lang/rust#40174 and rust-lang/rust#59302 seem like the correct places to work out what to do. If I had to take a wild guess, I would say rust-lang/rust#40174 (comment) sounds promising. |
Fix building proc-macro crates on musl host when --target is specified.