Closed
Conversation
Suggest using a lock instead.
This is a convenience feature for cases in which "no value in the table" and "default value in the table" are equivalent. Tables using `Table<DefIndex, ()>` are migrated in this PR, some other cases can be migrated later. This helps `DocFlags` in rust-lang#107136 in particular.
Adds an additional hint to failures where we encounter an else keyword while we're parsing an if-let block. This is likely that the user has accidentally mixed if-let and let...else together.
…ckh726 Add hint for missing lifetime bound on trait object when type alias is used Fix issue rust-lang#103582. The problem: When a type alias is used to specify the return type of the method in a trait impl, the suggestion for fixing the problem of "missing lifetime bound on trait object" of the trait impl will not be created. The issue caused by the code which searches for the return trait objects when constructing the hint suggestion is not able to find the trait objects since they are specified in the type alias path instead of the return path of the trait impl. The solution: Trace the trait objects in the type alias path and provide them along with the alias span to generate the suggestion in case the type alias is used in return type of the method in the trait impl.
…r=compiler-errors Suggest coercion of `Result` using `?` Fix rust-lang#47560.
…ees, r=dtolnay Allow fmt::Arguments::as_str() to return more Some(_). This adjusts the documentation to allow optimization of format_args!() to be visible through fmt::Arguments::as_str(). This allows for future changes like rust-lang#106824.
…tic, r=WaffleLapkin Suggest using a lock for `*Cell: Sync` bounds I mostly did this for `OnceCell<T>` at first because users will be confused to see that the `OnceCell<T>` in `std` isn't `Sync` but then extended it to `Cell<T>` and `RefCell<T>` as well.
rustc_metadata: Support non-`Option` nullable values in metadata tables This is a convenience feature for cases in which "no value in the table" and "default value in the table" are equivalent. Tables using `Table<DefIndex, ()>` are migrated in this PR, some other cases can be migrated later. This helps `DocFlags` in rust-lang#107136 in particular.
…ntal-let-else, r=compiler-errors Add suggestion to remove if in let..else block Adds an additional hint to failures where we encounter an else keyword while we're parsing an if-let expression. This is likely that the user has accidentally mixed if-let and let..else together. Fixes rust-lang#103791.
…mpiler-errors `new_outside_solver` -> `evaluate_root_goal` r? ``@rust-lang/initiative-trait-system-refactor``
rustbot
added
A-translation
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit fd3bca1 with merge 3a60d90e0167dee7e76124d44ffe2086588128fd... |
Member
|
The |
Contributor
|
@bors treeclosed=10 Closing the tree until the aarch64-gnu runner can be restarted. |
This was referenced Jan 24, 2023
Merged
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
|
aarch64-gnu seems to be running now. |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
Collaborator
|
⌛ Testing commit fd3bca1 with merge 4f8f988f0122e74743f9249657d5aa058efec324... |
Member
|
@bors retry yield to stable release |
Collaborator
Collaborator
|
⌛ Testing commit fd3bca1 with merge 6784be61dc11700dabb3dc530dbac9cff34be246... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
Collaborator
|
☔ The latest upstream changes (presumably #107314) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Resultusing?#106583 (Suggest coercion ofResultusing?)*Cell: Syncbounds #106944 (Suggest using a lock for*Cell: Syncbounds)Optionnullable values in metadata tables #107166 (rustc_metadata: Support non-Optionnullable values in metadata tables)new_outside_solver->evaluate_root_goal#107227 (new_outside_solver->evaluate_root_goal)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup