Skip to content

Conversation

@zkpepe
Copy link

@zkpepe zkpepe commented Sep 18, 2025

made the setup script more reliable:

  • MIRRORS_BASE now errors if missing.
  • RUST_CONFIGURE_ARGS defaults to empty.
  • mkdir -p ninja avoids “already exists” errors.
  • curl -fLo follows redirects and fails on HTTP errors.

simple, clear, and it just works.

@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 18, 2025
Comment on lines +9 to +11
# Check and set default values for variables
: "${MIRRORS_BASE:?MIRRORS_BASE is not set}"
: "${RUST_CONFIGURE_ARGS:=}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Check and set default values for variables
: "${MIRRORS_BASE:?MIRRORS_BASE is not set}"
: "${RUST_CONFIGURE_ARGS:=}"
# Fail is variable is not set
: "${MIRRORS_BASE:?MIRRORS_BASE is not set}"
# Set the variable to an empty string if it's undefined
: "${RUST_CONFIGURE_ARGS:=}"

@marcoieni
Copy link
Member

Thanks, this looks good, I just left a small improvements for the comment.
After you make the change, please squash your commits and I will approve 🙏

@reddevilmidzy reddevilmidzy added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants