array_chunks: remove Option wrapper from into_remainder's return type#148249
Closed
hkBst wants to merge 1 commit intorust-lang:mainfrom
Closed
array_chunks: remove Option wrapper from into_remainder's return type#148249hkBst wants to merge 1 commit intorust-lang:mainfrom
hkBst wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
This comment has been minimized.
This comment has been minimized.
5f78b4e to
78f5c2b
Compare
scottmcm
reviewed
Nov 17, 2025
Comment on lines
+50
to
+53
| while self.remainder.is_none() { | ||
| let _ = self.next(); | ||
| } | ||
| self.remainder | ||
| self.remainder.unwrap() |
Member
There was a problem hiding this comment.
Would it be worth restructuring this to avoid needing the unwrap?
I'm imagining something like
Suggested change
| while self.remainder.is_none() { | |
| let _ = self.next(); | |
| } | |
| self.remainder | |
| self.remainder.unwrap() | |
| loop { | |
| if let Some(r) = self.remainder { | |
| return r; | |
| } | |
| let _ = self.next(); | |
| } |
Member
Author
There was a problem hiding this comment.
While that is indeed equivalent it has the downside of the loop then being slightly more complicated, but let me know if you want it changed.
@rustbot ready
Member
|
closing this since #149127 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies
into_remainder's return type.