Suggest async block instead of async closure when possible#152042
Open
chenyukang wants to merge 2 commits intorust-lang:mainfrom
Open
Suggest async block instead of async closure when possible#152042chenyukang wants to merge 2 commits intorust-lang:mainfrom
chenyukang wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
JohnTitor
reviewed
Feb 5, 2026
| && obligation.cause.span.contains(*arg_span) | ||
| { | ||
| err.span_suggestion_verbose( | ||
| arg_span.with_hi(arg_span.hi() + rustc_span::BytePos(1)), |
Member
There was a problem hiding this comment.
It's an edge-case but the suggestion would be broken if there's no whitespace, like:
takes_future(async||{
chenyukang
force-pushed
the
yukang-fix-140265-async-closure-suggestion
branch
from
ab0f461 to
1a4fcc1
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140265
r? @estebank