Skip to content

Implement stdio FD constants#152071

Open
hanna-kruppe wants to merge 1 commit intorust-lang:mainfrom
hanna-kruppe:stdio-fd-consts
Open

Implement stdio FD constants#152071
hanna-kruppe wants to merge 1 commit intorust-lang:mainfrom
hanna-kruppe:stdio-fd-consts

Conversation

@hanna-kruppe
Copy link
Contributor

@hanna-kruppe hanna-kruppe commented Feb 3, 2026

Tracking issue: #150836

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 3, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2026

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

/// whenever possible. However, there are situations where touching the `std::io` handles (or most
/// other parts of the standard library) risks deadlocks or other subtle bugs. For example:
///
/// - Global allocators must be careful to [avoid reentrancy][global-alloc-reentrancy], and the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be moved to a new section in the BorrowedFd docs rather than being on STDERR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which parts and why? I could see some of it being relevant or at least instructive for general BorrowedFd docs (e.g., discussion of BorrowedFd<'static> implications, or the std::io handle vs. underlying FD differences, since that also matters for using AsFd on the handles). But e.g. for the bullet point your comment is attached to, I don't see how it would relate to BorrowedFd docs at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants