Use delayed_bug instead of asserting infcx is tainted#152095
Open
meithecatte wants to merge 1 commit intorust-lang:mainfrom
Open
Use delayed_bug instead of asserting infcx is tainted#152095meithecatte wants to merge 1 commit intorust-lang:mainfrom
meithecatte wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @jdonszelmann. Use |
Contributor
|
My approach for resolving this FIXME would be to analyze where the None passed to expect_and_resolve_type came from and whether we can refactor things to get rid of the Option entirely by erroring earlier. |
This resolves a FIXME but is otherwise inconsequential.
meithecatte
force-pushed
the
push-wynzsmrysmsy
branch
from
7276437 to
f09751d
Compare
Contributor
Author
|
That makes sense! Let me go CI-fishing for examples that hit that codepath... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a FIXME but is otherwise inconsequential.