Skip to content

DRAFT: consistent Windows PATH parsing#152138

Draft
betseg wants to merge 2 commits intorust-lang:mainfrom
betseg:issue-111832-windows
Draft

DRAFT: consistent Windows PATH parsing#152138
betseg wants to merge 2 commits intorust-lang:mainfrom
betseg:issue-111832-windows

Conversation

@betseg
Copy link

@betseg betseg commented Feb 4, 2026

This is my first pull request, and Dylan is helping me get used to the process. This PR should fix the inconsistency at #111832 . Neither I nor Dylan have a local Windows development environment, so we're hoping the CI has us covered.

cc @Dylan-DPC

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@betseg
Copy link
Author

betseg commented Feb 4, 2026

I was told tagging a PR as a draft would prevent the bot from assigning a reviewer, but I guess I misunderstood how that works. Sorry about the ping.

@Urgau
Copy link
Member

Urgau commented Feb 4, 2026

I was told tagging a PR as a draft would prevent the bot from assigning a reviewer, but I guess I misunderstood how that works. Sorry about the ping.

The PR wasn't opened in draft mode, hence why the bot assigned someone.

@rust-log-analyzer

This comment has been minimized.

@betseg
Copy link
Author

betseg commented Feb 4, 2026

Ah, I didn't know that was a thing, thanks.

@betseg betseg marked this pull request as draft February 4, 2026 21:04
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2026
@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   9 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-windows Operating system: Windows S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants