mGCA: Support directly represented negated literals#152139
Open
khyperia wants to merge 1 commit intorust-lang:mainfrom
Open
mGCA: Support directly represented negated literals#152139khyperia wants to merge 1 commit intorust-lang:mainfrom
khyperia wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy HIR ty lowering was modified cc @fmease |
Member
|
can you add tests for "nonsensical" negated literals, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #152123
PatExprKind already awkwardly tacks on a
negated: boolfor the same purpose:rust/compiler/rustc_hir/src/hir.rs
Lines 1954 to 1959 in 8bccf12
perhaps one day we should indeed do that FIXME...
r? @BoxyUwU