Rollup of 5 pull requests

[Dylan-DPC-zz]

Successful merges:

• reword "possible candidate" import suggestion #71903 (reword "possible candidate" import suggestion)
• Add some regression tests #71952 (Add some regression tests)
• tests: Fix warnings in rust_test_helpers.c #71959 (tests: Fix warnings in rust_test_helpers.c)
• Grammar #71962 (Grammar)
• use hex for pointers in Miri error messages #71972 (use hex for pointers in Miri error messages)

Failed merges:

r? @ghost

[Dylan-DPC-zz]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1f73d8d has been approved by Dylan-DPC

[bors]

⌛ Testing commit 1f73d8d with merge b7d2d2caa3cd019770b06e24920f20126db10cdb...

[bors]

💔 Test failed - checks-actions

[Dylan-DPC-zz]

@bors retry

[bors]

⌛ Testing commit 1f73d8d with merge 9a32b4ad89ea74677eaa678f7580394d59c75bd6...

[RalfJung]

The log says

stderr:
------------------------------------------
D:\a\rust\rust\src/test\codegen\ffi-out-of-bounds-loads.rs:18:12: error: CHECK: expected string not found in input
 // CHECK: load { i64, i32 }, { i64, i32 }* {{.*}}, align 4
           ^
D:\a\rust\rust\build\x86_64-pc-windows-msvc\test\codegen\ffi-out-of-bounds-loads\ffi-out-of-bounds-loads.ll:1:1: note: scanning from here
; ModuleID = 'ffi_out_of_bounds_loads.7rcbfp3g-cgu.0'
^
D:\a\rust\rust\build\x86_64-pc-windows-msvc\test\codegen\ffi-out-of-bounds-loads\ffi-out-of-bounds-loads.ll:52:8: note: possible intended match here
 %_2 = load i32, i32* %self, align 4
       ^

------------------------------------------



failures:
    [codegen] codegen\ffi-out-of-bounds-loads.rs

That codegen test was added in #71952.
This doesn't quite look spurious?

[RalfJung]

However @pietroalbini something is wrong with whatever bors linked to above, both here and in #71966: it linked to https://github.com/rust-lang-ci/rust/runs/653177525 which just says "mark the job as a failure",

Run exit 1
##[error]Process completed with exit code 1.

One has to ignore that and find the actual failing job in the list on the left to figure out what happened.

[Dylan-DPC-zz]

Yeh i got a different thing (maybe a different build) hence assumed spurious. I'll r- that one and re-roll

[bors]

💔 Test failed - checks-actions

[emilyalbini]

@RalfJung opened #71987 to track your feedback.