Skip to content

Fix loading pretty-printers in rust-lldb script#76015

Merged
bors merged 1 commit intorust-lang:masterfrom
artemmukhin:fix-lldb-script
Aug 30, 2020
Merged

Fix loading pretty-printers in rust-lldb script#76015
bors merged 1 commit intorust-lang:masterfrom
artemmukhin:fix-lldb-script

Conversation

@artemmukhin
Copy link
Contributor

@artemmukhin artemmukhin commented Aug 28, 2020

Pretty-printers loading in rust-lldb script was broken in #72357

This fixes #76006

@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 28, 2020

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2020
ehuss
ehuss approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and it seems to work for me.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Aug 28, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 28, 2020

📌 Commit 9cdcfe2 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2020
@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 28, 2020
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Aug 28, 2020

beta-nominating as a fix for a regression

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 29, 2020
@Dylan-DPC
Rollup merge of rust-lang#76015 - ortem:fix-lldb-script, r=Mark-Simul…
53f2dc8 
…acrum

Fix loading pretty-printers in rust-lldb script

Pretty-printers loading in `rust-lldb` script was broken in rust-lang#72357

This fixes rust-lang#76006
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Aug 29, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 29, 2020
@Dylan-DPC
Rollup merge of rust-lang#76015 - ortem:fix-lldb-script, r=Mark-Simul…
3de529d 
…acrum

Fix loading pretty-printers in rust-lldb script

Pretty-printers loading in `rust-lldb` script was broken in rust-lang#72357

This fixes rust-lang#76006
This was referenced Aug 29, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 30, 2020
@bors
Auto merge of rust-lang#76090 - Dylan-DPC:rollup-eksndcr, r=Dylan-DPC
62850d8 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#75832 (Move to intra-doc links for wasi/ext/fs.rs, os_str_bytes.rs…)
 - rust-lang#75852 (Switch to intra-doc links in `core::hash`)
 - rust-lang#75874 (Shorten liballoc doc intra link while readable)
 - rust-lang#75881 (Expand rustdoc theme chooser x padding)
 - rust-lang#75885 (Fix another clashing_extern_declarations false positive.)
 - rust-lang#75892 (Fix typo in TLS Model in Unstable Book)
 - rust-lang#75910 (Add test for issue rust-lang#27130)
 - rust-lang#75917 (Move to intra doc links for core::ptr::non_null)
 - rust-lang#75975 (Allow --bess ing expect-tests in tools)
 - rust-lang#75990 (Add __fastfail for Windows on arm/aarch64)
 - rust-lang#76015 (Fix loading pretty-printers in rust-lldb script)
 - rust-lang#76022 (Clean up rustdoc front-end source code)
 - rust-lang#76029 (Move to intra-doc links for library/core/src/sync/atomic.rs)
 - rust-lang#76057 (Move retokenize hack to save_analysis)

Failed merges:

r? @ghost
@bors bors merged commit 063313b into rust-lang:master Aug 30, 2020
@spastorino
Copy link
Member

spastorino commented Sep 3, 2020

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 3, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 17, 2020
@Mark-Simulacrum Mark-Simulacrum added this to the 1.47.0 milestone Sep 17, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2020
@bors
Auto merge of rust-lang#76852 - Mark-Simulacrum:beta-next, r=Mark-Sim…
755064b 
…ulacrum

[beta] backports

* Ignore rustc_private items from std docs rust-lang#76571
* Fix HashMap visualizers in Visual Studio (Code) rust-lang#76389
* Account for version number in NtIdent hack rust-lang#76331
* Account for async functions when suggesting new named lifetime rust-lang#75867
* Fix loading pretty-printers in rust-lldb script rust-lang#76015

This also bumps to the released stable compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehuss ehuss ehuss approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

lldb debugging is not working from version 1.46

7 participants

@artemmukhin @rust-highfive @Mark-Simulacrum @bors @spastorino @ehuss @rustbot