[rustdoc] Box some more ItemKind variants#79975
Closed
jyn514 wants to merge 7 commits intorust-lang:masterfrom
Closed
[rustdoc] Box some more ItemKind variants#79975jyn514 wants to merge 7 commits intorust-lang:masterfrom
jyn514 wants to merge 7 commits intorust-lang:masterfrom
Conversation
This should *vastly* reduce memory usage.
This was simpler than expected.
- Use a tuple struct instead of a single field - Enforce calling `source_callsite()` by making the inner span private - Rename `empty` to `dummy`
jyn514
added
T-rustdoc
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
I also tried boxing the |
This brings the sizes down to ``` [src/librustdoc/lib.rs:102] std::mem::size_of::<Item>() = 520 [src/librustdoc/lib.rs:102] std::mem::size_of::<ItemKind>() = 248 ``` from ``` [src/librustdoc/lib.rs:102] std::mem::size_of::<Item>() = 608 [src/librustdoc/lib.rs:102] std::mem::size_of::<ItemKind>() = 336 ```
This reduces the size from ``` [src/librustdoc/lib.rs:102] std::mem::size_of::<Item>() = 520 [src/librustdoc/lib.rs:102] std::mem::size_of::<ItemKind>() = 248 ``` to ``` [src/librustdoc/lib.rs:102] std::mem::size_of::<Item>() = 432 [src/librustdoc/lib.rs:102] std::mem::size_of::<ItemKind>() = 160 ```
jyn514
force-pushed
the
smaller-item-kind-2
branch
from
ef93f6f to
5a24faf
Compare
Member
Author
|
See #79967 (comment), I would prefer to go with #80014. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #79967 and #79957 and should not be merged before. Helps with #79103.