Inline DebruijnIndex methods

[LeSeulArtichaut]

Attempts to fix the perf regression from #79169. Could someone queue a perf run for this?

r? @nikomatsakis cc @rylev

[rylev]

@bors try @rust-timer queue

[rust-timer]

Insufficient permissions to issue commands to rust-timer.

[bors]

⌛ Trying commit 2208f5e with merge d556efc2d01383e316fdb5a9cad3ba9df3f9b0fb...

[lqd]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

[bors]

⌛ Trying commit 2208f5e with merge c49e4b740ec507a6d372a03481e2990c33c1dade...

[bors]

☀️ Try build successful - checks-actions
Build commit: c49e4b740ec507a6d372a03481e2990c33c1dade (c49e4b740ec507a6d372a03481e2990c33c1dade)

[rust-timer]

Queued c49e4b740ec507a6d372a03481e2990c33c1dade with parent 99baddb, future comparison URL.

@rustbot label: +S-waiting-on-perf

[rust-timer]

Finished benchmarking try commit (c49e4b740ec507a6d372a03481e2990c33c1dade): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[LeSeulArtichaut]

This doesn't seem to fix the performance 😕

[jackh726]

I wonder if it's the functions on TypeFlags?

[LeSeulArtichaut]

I wonder if it's the functions on TypeFlags?

IIUC those already have #[inline] (see e.g. empty)...

[LeSeulArtichaut]

What should I do with this? Should I close it? Should we merge it?

[rylev]

If this isn't improving performance, I don't see why we should merge it. Thoughts?

[LeSeulArtichaut]

Yeah, I'll just close this.

[jackh726]

With regards to #79169, the only other function that got moved out was the hash_stable on DebruijnIndex. Other than that, there's not a clear target for inlining.