Rollup of 6 pull requests#84389
Closed
Dylan-DPC-zz wants to merge 18 commits intorust-lang:masterfrom
Closed
Conversation
…nnytm fix 'const-stable since' for NonZeroU*::new_unchecked For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that. I think this `since` is also incorrect: ```rust #[stable(feature = "from_nonzero", since = "1.31.0")] impl From<$Ty> for $Int { ``` The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
Document that `index` and `index_mut` can panic I thought this was noteworthy and I think a bit more explicitness does no harm.
…=jonas-schievink ⬆️ rust-analyzer
…trochenkov Improve the docstrings of the `Lto` struct. This change is the result of [this zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Making.20sense.20of.20LTO.20modes.20in.20rustc). Hopefully it makes things a little clearer. What do you think?
Fix broken doc link
…=jackh726 Add GAT related tests Closes rust-lang#79949 Closes rust-lang#79636 Closes rust-lang#78671 Closes rust-lang#70303 Closes rust-lang#70304 Closes rust-lang#71176
Author
|
@bors r+ rollup=never p=5 |
Collaborator
|
📌 Commit f2b4d4c has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit f2b4d4c with merge 8bd8c1ba9b372530cd937fc6e51e54993f257c99... |
Collaborator
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Author
|
@bors retry |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit f2b4d4c with merge d6270f13a1f6771287a33303866e778cb5825f0b... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors treeclosed=1000 This keeps happening: Looking into it. |
This was referenced Apr 21, 2021
Merged
Member
|
Fix is being merged: #84394 Closing this rollup PR, since there's more rollup'able PRs waiting now. |
This was referenced Apr 21, 2021
This was referenced Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
indexandindex_mutcan panic #84301 (Document thatindexandindex_mutcan panic)Ltostruct. #84365 (Improve the docstrings of theLtostruct.)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup