ExitCode docs improvements#95389
Closed
coolreader18 wants to merge 2 commits intorust-lang:masterfrom
Closed
Conversation
rustbot
added
the
T-compiler
Contributor
|
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
Can you change the base branch from master to my branch in the stabilization PR, |
Contributor
Author
|
Eeek, I don't think so, I'd have to make a new PR in your fork I think. |
Contributor
Author
|
I could squash and you could cherry-pick? |
coolreader18
force-pushed
the
exitcode-docs-improvements
branch
from
247bbe8 to
4a35b7a
Compare
Member
Yea, sounds good, thank you! |
Member
|
I've merged the touch up commit, thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how changes made during a fcp should be PR'd, obviously this isn't needed for the stabilization so I just based it off the stabilization branch.
r? yaahc