[5.x] Apply bottom padding to main nav #12012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Daun <[email protected]>
Member
|
Nice one, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the tiniest of papercuts: apply a bottom padding to the main nav. Besides the visual aspect, we've been hearing from some users that their browser won't let them click the bottom link because it's hidden behind the browser's status bar. Chrome's status bar does move out of the way helpfully, but apparently some browsers don't do that.
The bottom padding needs to be applied to the last
ulbecause of flexbox reasons :/Also applies the
100% - 52pxlogic to mobile as well to make scrolling there easier.Before
After