[5.x] Prevent null parse_url deprecation warning #12197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP Deprecated parse_url(): Passing null to parameter #1 ($url) of type string is deprecated
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a PHP deprecation warning that occurs when parse_url() receives a null value, which is deprecated in newer PHP versions. The fix ensures that the referer header value defaults to an empty string when null.
- Adds null coalescing operator to prevent null values from being passed to
parse_url()
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jasonvarga
changed the title
edalzell
reviewed
Aug 27, 2025
Contributor
|
hahaha, lol, perhaps I should wake up before commenting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR repairs a possible null in parse_url() argument.
PHP Deprecated
parse_url(): Passing null to parameter # 1 ($url) of type string is deprecated