[5.x] Make UpdateAssetReferences overwritable #12283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently exploring ways to build an asset index that tracks asset usage throughout the cms, to make updating references more performant in a system with a large amount of entries. In a lot of ways the current structure makes that very easy by overwriting/extending some parts of the
UpdateAssetReferencessubscriber.However, when replacing an asset, the Asset class temporarily disables the Subscriber to not react to the
AssetDeletedevent, if the "delete old asset"-option is enabled. Unfortunately this doesn't affect my custom class, that I've bound in a service provider.So, this PR simply changes these
enable()anddisable()calls to use the service container 😇If you have any other ideas/suggestions on how to solve this instead, I'm happy for any input.