[5.x] Registering a custom preset should update existing Server instance
#12660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the custom image manipulation presets feature added in #12624, where custom presets wouldn't be available on the Glide server if the
Serverinstance had already been resolved.This was causing an issue in SEO Pro's tests because social images were returning their original width/height, instead of the width/heights defined in the preset.
It turned out that the Glide
Serverinstance was being resolved before we were callingImage::registerCustomManipulationPresets()in SEO Pro's service provider.This PR fixes it by updating the
Serverinstance's presets array when registering a custom preset.Related: statamic/seo-pro#427