[5.x] Add overlaps and doesnt_overlap conditions and modifiers
#9491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmitchell
changed the title
includes condition and modifierincludes and doesnt_include conditions and modifiers
ryanmitchell
changed the title
includes and doesnt_include conditions and modifiersincludes and doesnt_include conditions and includes modifier
|
Good job! This is very useful and will solve not being able to filter by any field that gets saved by an array (like multiple select, checkboxes etc). |
Contributor
|
This is very useful, and seems to work like a charm. I ran into a Statamic limitation and @afonic pointed me to your PR Ryan. Thanks both. |
Contributor
|
Jason do you reckon this will make the cut someday and I can patch it in? Otherwise I'll work on a query scope instead. |
Member
More than likely, but not 100% sure. |
Contributor
|
Gotcha. Thanks Jason. |
Contributor
|
Nice! This will close statamic/ideas#910 |
ryanmitchell
changed the title
includes and doesnt_include conditions and includes modifierincludes and doesnt_include conditions and includes modifier
ryanmitchell
changed the title
includes and doesnt_include conditions and includes modifierincludes and doesnt_include conditions and modifiers
1 task
Member
Contributor
Author
|
I guess it could be overlaps/doesnt_overlap now? |
ryanmitchell
changed the title
includes and doesnt_include conditions and modifiersoverlaps and doesnt_overlap conditions and modifiers
Contributor
Author
|
@jasonvarga thanks for merging #11112 - I've updated this to be overlaps/doesnt_overlap now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second go at this and is an alternative to / replaces #8357
This PR adds an
overlapsmodifier and tag condition, as well as adoesnt_overlaptag condition. The Modifier is intentionally a loose comparison, so if any of the values in needle are found it counts as a match. This is to mirror howwhereJsonOverlaps()works on the builder side.Closes statamic/ideas#910