[5.x] Fix ordering nulls before non-nulls #11976
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding fields to an existing blueprint, the newly created fields will have a value of null. When ordering by the newly created field you'd expect those without values would be placed after those with values. This PR changes the comparison between nulls and non-nulls so that nulls are placed after non-nulls.
I realize this is a large change in that it could affect a lot, but I believe the way this functions now is not desired or expected behavior.
Example where this matters:
Also in favor of this change, if you create an array in PHP and sort it you get the expected orders - with null coming after non-null: