Repository navigation
Conversation
Format a fixed date with each pattern and compare the result with the example given in the pattern's documentation. Signed-off-by: Ruby20-50 <rubamogalli@gmail.com>
alperozturk96
requested changes
Nov 2, 2026
| * Nextcloud - Android Client | ||
| * | ||
| * SPDX-FileCopyrightText: 2026 <Ruba Mogalli> <rubamogalli@gmail.com> | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later OR GPL-2.0-only |
Collaborator
There was a problem hiding this comment.
Hey,
Thank you for the PR. Could you please update license header via AGPL-3.0-or-later?
| } | ||
|
|
||
| @Test | ||
| fun monthWithDate_formatsShortMonthAndDay() { |
Collaborator
There was a problem hiding this comment.
Can we have function name like this: https://kotlinlang.org/docs/coding-conventions.html#names-for-test-methods ?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for
DateFormatPattern.Each test formats a fixed date (3 August 2024, 14:38, English locale) with one
pattern and checks the result against the example in the pattern's
documentation. The tests are plain JVM unit tests and need no Android SDK.
Run with:
.\gradlew.bat testGplayDebugUnitTest --tests "com.nextcloud.utils.date.DateFormatPatternTest"
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)
I wrote and adapted this PR myself, with help from an AI assistant. It
helped review the test, the commit message and explained
the contribution workflow. I initiated the code, ran the tests and the style
checks locally, and fixed problems along the way.