Repository navigation
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 28325 ms |
Contributor
TPC-DS: Total hot run time: 150684 ms |
Contributor
ClickBench: Total hot run time: 24.29 s |
Contributor
Author
|
run check_coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A (related to #69928)
Related PR: #69929
Problem Summary:
SHOW CREATE ROUTINE LOADcurrently omits two supported job properties from its generated CREATE statement:send_batch_parallelismload_to_single_tabletAlthough both properties are accepted by
CREATE ROUTINE LOADand represented in the job's runtime configuration, they are not included byRoutineLoadJob.getShowCreateInfo().Consequently, the generated DDL does not faithfully represent these execution settings. Recreating a job using the generated statement can cause the omitted properties to revert to their defaults.
Changes
send_batch_parallelismandload_to_single_tabletin the generatedPROPERTIESclause.Behavior and Compatibility
Both properties are emitted with their effective runtime values, including when their defaults are used. This is consistent with the existing behavior of
SHOW CREATE ROUTINE LOAD, which renders effective values for other job properties.This change affects only the generated DDL. It does not modify Routine Load execution, metadata serialization, deserialization, property validation, or Kafka progress.
The fix is independently mergeable from #69929, which restores configured runtime properties during FE recovery. Both changes are complementary but have separate responsibilities.
Scope and Follow-up
This PR intentionally addresses only
send_batch_parallelismandload_to_single_tablet.Additional supported properties, including Unique Key update settings, workload-group configuration, and CSV formatting options, are also omitted from
SHOW CREATE ROUTINE LOAD.These omissions will be investigated and addressed separately, with additional validation for their respective configuration semantics and SQL round-trip behavior.
This PR does not claim to provide complete
SHOW CREATE ROUTINE LOADconfiguration fidelity.Release note
SHOW CREATE ROUTINE LOADnow includessend_batch_parallelismandload_to_single_tabletin the generated CREATE statement.Check List (For Author)
Unit Test
Extended
RoutineLoadJobTestto verify:Also executed
ShowCreateRoutineLoadCommandTestto validate the surrounding SHOW CREATE command.Manual Test
Use an existing paused Routine Load job configured with:
send_batch_parallelism = 2load_to_single_tablet = trueCapture the job's configuration and generated CREATE statement before deploying the fix.
Deploy a development FE containing the SHOW CREATE change.
Execute:
Verify the generated CREATE statement now includes:
Confirm the job ID, state, effective configuration, and stored Kafka progress remain unchanged.
Restore the original development FE binary.
Test Results
Unit Tests — PASSED
RoutineLoadJobTest— including the updated exact-output test and the new test for nondefault property values.ShowCreateRoutineLoadCommandTest— existing command-level tests passed.FE Build — PASSED
./build.sh --fecompleted successfully.Manual Verification — PASSED
rl_recovery_newinrl_recovery_verify.SHOW CREATE ROUTINE LOADpreviously omittedsend_batch_parallelismandload_to_single_tablet.Behavior changed:
SHOW CREATE ROUTINE LOADnow includes the two previously omitted properties.Does this need documentation?
No new SQL syntax or configuration options are introduced.
Check List (For Reviewer who merge this PR)