Repository navigation
Conversation
`CreateFunction` assigned `pointer` with `Object::Set`, which walks `Function.prototype`. A non-writable inherited `pointer` turned the store into a silent no-op, so the function reported the inherited value instead of its native address. Use `CreateDataProperty`. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
ffi
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67170 +/- ##
==========================================
- Coverage 90.68% 90.68% -0.01%
==========================================
Files 797 797
Lines 278790 278790
Branches 53617 53607 -10
==========================================
- Hits 252834 252809 -25
- Misses 16303 16345 +42
+ Partials 9653 9636 -17
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Nov 1, 2026
trivikr
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
ShogunPanda
approved these changes
Nov 1, 2026
trivikr
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #67169
CreateFunctionassignedpointerwithObject::Set, which walksFunction.prototype. A non-writable inheritedpointerturned the store into a silent no-op, so the function reported the inherited value instead of its native address. UseCreateDataProperty.Assisted-by: claude:opus-5.5