Repository navigation
[6.x] Fix dragging assets onto folders in list view - #15676
Merged
Merged
Conversation
jasonvarga
force-pushed
the
15675-list-view-folder-drop
branch
from
October 20, 2026 20:41
5d9946a to
db6e1c2
Compare
- Table never declared the assets prop, so dropping an asset on a folder row threw and nothing moved - Track the hovered row separately, rather than overwriting draggingFolder on dragover
jackmcdade
force-pushed
the
15675-list-view-folder-drop
branch
from
October 22, 2026 18:44
db6e1c2 to
fa0b732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
In the asset browser's list view, dropping an asset onto a folder row throws
Cannot read properties of undefined (reading 'find')and nothing moves. Grid view works.What this PR Does
Tableusesthis.assetsto find the dragged asset but never declared theassetsprop, so it was undefined. It's declared now, the same wayGriddoes it.draggingFolder, the same value that tracks a folder being dragged. Hovering now has its owndragOverFolder, as inGrid.list-view-folder-drop.mp4
How to Reproduce