Repository navigation
[6.x] Fix update badge showing "0" when using Redis as cache store - #15767
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cache store is Redis, the Updates item in the Control Panel nav shows an amber badge with "0" even when there are no updates.
UpdatesOverviewcaches the update count as an integer. Laravel'sRedisStoresaves numeric values without serializing them, and reading them back returns strings. So/cp/updater/countresponds with{"count": "0", ...}.UpdatesBadgerenders withv-if="count", and since"0"is truthy in JavaScript, the badge shows.The other cached values (
statamic,security,addons) aren't affected, because booleans and arrays get serialized and keep their type.This PR casts the count to an integer in
UpdatesOverview::count(). That matches the existing@return intdocblock andbadge()'sarray{count: int, security: bool}shape.Thanks to Ash for reporting this through support!