Repository navigation
[6.x] Speed up permission checks - #15773
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request speeds up permission checks by caching the values of the flattened permissions.
Statamic's
Gate::aftercallback checks whether an ability is a Statamic permission before getting involved. To do that, it mapped every flattened permission (~475 of them) to its value on every single gate check.#12258 already caches the flattened permissions, so this PR caches their values in a lookup alongside them, via a new
Permissions::contains()method. The values come from the same cached, flattened permissions, so the result of every check is the same as before. It's just quicker to get to.On an entry where the publish form makes ~2,300 permission checks (mostly from Assets fields), this saved ~190ms.
Related: #12258
Related: #13385