Repository navigation
Job Batching - #16
Merged
Merged
Job Batching#16
Conversation
This reverts commit 0ffa848.
duncanmcclean
force-pushed
the
job-batches
branch
from
October 30, 2024 12:01
86b0265 to
f17545c
Compare
duncanmcclean
marked this pull request as ready for review
October 30, 2024 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements Laravel's job batching feature, allowing us to group together all the jobs for a single import and determine if an import has been completed or not.
While these changes don't introduce any kind of progress indicator, it will make that easier in the future if we decide to add it.
Job batching does require a database in order to store information about the batches (like whether all the jobs have completed, the total number of jobs in a batch, etc). Since all new Statamic sites use SQLite by default, no additional configuration is required.
If you haven't already run the app's base migrations (which includes the
job_batchestable), the addon will attempt to run them automatically when you create an import.If the migrations can't be run automatically, for whatever reason, a banner will be displayed on the import edit page: