Repository navigation
Fix import issue with Bard - #65
Merged
Merged
Conversation
duncanmcclean
added a commit
that referenced
this pull request
Jan 8, 2025
This reverts commit 9e512d0.
duncanmcclean
added a commit
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue when importing Bard fields where if the provided HTML doesn't wrap text in
<p>tags, it would cause the text to be in-editable in the Control Panel.Due to the lack of
<p>tags, ProseMirror was outputtingtextnodes. However, in order for them to be editable (& formatted properly in Bard), they need to be wrapped inparagraphnodes.See an example below:
This PR also fixes an issue where indexes were being outputted by the Bard transformer, which they shouldn't have been.
Fixes #62.