Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 97e14d99f6def189b0f786ac6207b792ca3197b1
Choose a base ref
...
head repository: git/git
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f006e0323ee4b407bee3e0ff241d9d3f7a03b66a
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 16, 2025

  1. CodingGuidelines: allow the use of bool 

    We have had a test balloon for C99's bool type since 8277dbe
(git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
2023-12-16). As we've had it over 18 months without any complaints
let's declare it a success.

Signed-off-by: Phillip Wood <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @phillipwood @gitster
    phillipwood authored and gitster committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    bfa405e View commit details
    Browse the repository at this point in the history

  2. git-compat-util: convert string predicates to return bool 

    Since 8277dbe (git-compat-util: convert skip_{prefix,suffix}{,_mem}
to bool, 2023-12-16) a number of our string predicates have been
returning bool instead of int. Now that we've declared that experiment
a success, let's convert the return type of the case-independent
skip_iprefix() and skip_iprefix_mem() functions to match the return
type of their case-dependent equivalents. Returning bool instead of
int makes it clear that these functions are predicates.

Signed-off-by: Phillip Wood <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @phillipwood @gitster
    phillipwood authored and gitster committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    f3ba426 View commit details
    Browse the repository at this point in the history

  3. strbuf: convert predicates to return bool 

    Now that the string predicates defined in git-compat-util.h all
return bool let's convert the return type of the string predicates
in strbuf.{c,h} to match them.

Signed-off-by: Phillip Wood <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
    @phillipwood @gitster
    phillipwood authored and gitster committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    f006e03 View commit details
    Browse the repository at this point in the history
Loading