Skip to content

Conversation

@npm1
Copy link
Collaborator

@npm1 npm1 commented Jul 11, 2025

This PR enforces that accounts_endpoint and login_url are present in the well-known file whenever the client_metadata is used. Fixes #700


Preview | Diff

This PR enforces that accounts_endpoint and login_url are present in the well-known file whenever the client_metadata is used. Fixes #700
@npm1
Copy link
Collaborator Author

npm1 commented Jul 11, 2025

@togamid can you take a look?

@togamid
Copy link
Contributor

togamid commented Jul 11, 2025

It's currently very easy to miss. Maybe also add an "extension" box at the end of the IdP well-known section that says "If the config endpoint returns a client_metadata endpoint, accounts_endpoint and login_url are always required" (or something similar). As it is it is likely that people who just skim the browser part because they want to implement an IdP miss it and wonder why their implementation fails.

@npm1
Copy link
Collaborator Author

npm1 commented Jul 14, 2025

It's currently very easy to miss. Maybe also add an "extension" box at the end of the IdP well-known section that says "If the config endpoint returns a client_metadata endpoint, accounts_endpoint and login_url are always required" (or something similar). As it is it is likely that people who just skim the browser part because they want to implement an IdP miss it and wonder why their implementation fails.

Done. Requesting review from Chrome but also CC @bvandersloot-mozilla as this only impacts the extension

@npm1 npm1 requested a review from cbiesinger July 14, 2025 14:57
@npm1 npm1 merged commit 2b9b7e7 into main Jul 14, 2025
2 checks passed
@npm1 npm1 deleted the fix-700 branch July 14, 2025 17:52
github-actions bot added a commit that referenced this pull request Jul 14, 2025
SHA: 2b9b7e7
Reason: push, by npm1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to mattdanielbrown/WebID that referenced this pull request Jul 15, 2025
SHA: 2b9b7e7
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking through IDP with individualized account and client_metadata endpoints

4 participants