Skip to content

Commit 643f9e8

Browse files
authored
fix(quick-edit): add missing variable scope to solarflare light theme (#11515)
* fix(solarflare-theme): add missing `variable` scope to light theme Light theme was missing the base `variable` scope in the Variables rule, causing JS/TS variables to fall back to the default editor foreground color (#62676A gray) instead of being highlighted. The dark theme correctly had `variable` which matches all variable.* tokens via TextMate prefix matching. The light theme only had `variable.other` which doesn't match plain `variable` scoped tokens. Also removes duplicate `variable.other.object` entries from both themes. * chore: add changeset
1 parent 88b1a78 commit 643f9e8

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"solarflare-theme": patch
3+
---
4+
5+
Fix light theme syntax highlighting for variables by adding missing `variable` scope

‎packages/solarflare-theme/themes/cloudflare-dark-color-theme.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
"string constant.other.placeholder",
4444
"variable.other.object",
4545
"variable.other.readwrite",
46-
"variable.other.object",
4746
"variable.other.property"
4847
],
4948
"settings": {

‎packages/solarflare-theme/themes/cloudflare-light-color-theme.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,10 @@
4848
{
4949
"name": "Variables",
5050
"scope": [
51+
"variable",
5152
"string constant.other.placeholder",
52-
"variable.other",
5353
"variable.other.object",
5454
"variable.other.readwrite",
55-
"variable.other.object",
5655
"variable.other.property"
5756
],
5857
"settings": {

0 commit comments

Comments
 (0)