Kotlin Language Adaptor

[MarioAriasC]

Langauge adaptor for kotlin

[cloudbees-pull-request-builder]

RxJava-pull-requests #165 FAILURE
Looks like there's a problem with this pull request

[MarioAriasC]

Is a problem with the Perm-Gen memory size when compiling the scala module after you download the kotlin libraries for the first time. The problem disappear growing up the Perm-Gen size, or running the whole process a second time

[benjchristensen]

Thank you for submitting this, I am not ignoring it due to lack of interest, I'm just overly busy at the moment but I will get around to this!

[MarioAriasC]

No problem

[codefromthecrypt]

@MarioAriasC you might want to redo this on a feature branch as there's a lot of clutter (merge commits, whoops I forgot this) here. I'll review anyway, but we are interested in merging concise, complete commits. make sense? Let me know if you need git syntax help.

[codefromthecrypt]

this is redundant

[MarioAriasC]

Needed by Kotlin Gradle plugin

[codefromthecrypt]

looks good to me. sufficient unit tests, etc. cleanup the files, build.gradle, and commit, then ask @benjchristensen!

[codefromthecrypt]

looking at your source, I don't see use of junit outside tests, mark this testCompile

[MarioAriasC]

@adriancole Any help with git syntax (and other things) will be very appreciated

[codefromthecrypt]

sure.

It looks like you are 7 commits ahead of master (merges plus the other things you've added)

do git reset HEAD~7 which should unstage your changes.

Then, you do git pull upstream master to reset your head to latest.
Then, redo your commit, and you'll need to do git push -f origin master to overwrite the commits here.

hope this helps.

[benjchristensen]

We are getting very close to being able to pull this in (with some refactoring) now that pull #300 is coming.

[benjchristensen]

Does Kotlin support closure/function coercion like Java 8 or Groovy 2.2 (http://docs.codehaus.org/display/GROOVY/2013/07/09/First+beta+of+Groovy+2.2+available) or allow dynamic generation of extension methods?

I see that Kotlin has extension methods, but every method must be defined manually.

I'm interested in a mechanism to automatically coerce from Kotlin functions to RxJava Function/Action classes, or dynamically generate the extension methods. Here's how I generate the extension methods dynamically in Groovy: https://github.com/Netflix/RxJava/blob/master/language-adaptors/rxjava-groovy/src/main/java/rx/lang/groovy/RxGroovyExtensionModule.java#L84

[benjchristensen]

For background on the previous questions and why it has been so long in responding to this pull request look at release 0.11.0 which significantly changes how we do language adaptors: https://github.com/Netflix/RxJava/releases/tag/rxjava-0.11.0

[MarioAriasC]

Kotlin support function coercion is called SAM (Single Abstract Method) Conversions, this support was introduced in M5.2 and completed in M6 http://blog.jetbrains.com/kotlin/2013/08/kotlin-m6-is-here/

Personally I used it in other project and works fine, but sometimes the compiler can infer the actual type of the interface, in those cases we could fall back on Extension methods.