Pass unsupported formats directly to the server#74910
Merged
adamsilverstein merged 3 commits intotrunkfrom Feb 18, 2026
Merged
Conversation
adamsilverstein
requested review from
ajitbohra,
ellatrix,
nerrad,
ntwb and
spacedmonkey
as code owners
github-actions
bot
added
[Package] Core data
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +50 B (0%) Total Size: 6.85 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d7ee109. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21646855553
|
adamsilverstein
added
[Type] Feature
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
adamsilverstein
removed request for
ajitbohra,
ellatrix,
nerrad,
ntwb and
spacedmonkey
adamsilverstein
changed the base branch from
trunk
to
feature/client-side-media-dev
adamsilverstein
requested review from
desrosj,
gigitux,
luisherranz,
ntsekouras,
oandregal and
tellthemachines
as code owners
adamsilverstein
requested review from
adamziel,
alexstine,
draganescu,
getdave,
gziolo,
kevin940726 and
ryanwelcher
as code owners
adamsilverstein
changed the base branch from
feature/client-side-media-dev
to
trunk
adamsilverstein
removed request for
a team,
ObliviousHarmony,
gziolo and
t-hamano
When a file's MIME type is not in the list of client-side supported formats (JPEG, PNG, GIF, WebP, AVIF), skip client-side processing and upload it directly to the server. This allows formats like HEIC, TIFF, BMP, and SVG to be uploaded without failing at the client-side processing step. Includes prerequisite files (use-upload-save-lock.js, use-media-upload-settings.js) from the client-side media feature branch needed for provider/index.js changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
rebased on trunk |
swissspidy
reviewed
Feb 16, 2026
Comment on lines
+18
to
+30
| /** | ||
| * MIME types supported by client-side media processing. | ||
| * | ||
| * These are the image formats that can be processed using | ||
| * WebAssembly-based vips in the browser. | ||
| */ | ||
| export const CLIENT_SIDE_SUPPORTED_MIME_TYPES: readonly string[] = [ | ||
| 'image/jpeg', | ||
| 'image/png', | ||
| 'image/gif', | ||
| 'image/webp', | ||
| 'image/avif', | ||
| ]; |
Member
There was a problem hiding this comment.
How was this list established?
In media-experiments I had this one:
(Also note the naming difference, image types vs mime types)
Member
Author
There was a problem hiding this comment.
Based on what we support in core already (which is whsat I'm trying to land), except core client side media won't support heic. Mayne need to add tif and jxl?
swissspidy
reviewed
Feb 16, 2026
Member
swissspidy
left a comment
swissspidy
left a comment
There was a problem hiding this comment.
The idea of the upload store is that each and every single file should go through the upload queue. There shouldn't be any distinction between client- and server-side files. Only a single, shared implementation.
If a file isn't supported by vips, it would simply not be processed by it, but simply go through the queue unchanged, until it will be eventually uploaded to the server directly. That's what prepareItem in the store is fore.
The change here breaks this idea/assumption.
Member
This would make for a great e2e test.
I think if every file goes to the queue properly (see comment above), then there shouldn't be a need for a second type of event. |
Member
Author
|
@andrewserong @swissspidy this one is ready for review. |
Member
|
I left some feedback yesterday :) |
Member
Author
Ok, that makes sense. In that case, we would upload the file and set the flag so the server creates the subsizes (or in the case of PDF/Imagick the thumbnail version. |
Member
Yes exactly, using the |
Instead of splitting files before the upload queue, check format support inside prepareItem() so all files go through the single upload queue. Unsupported formats (PDFs, SVGs, videos, etc.) skip vips operations and upload directly to the server. This addresses reviewer feedback that the queue should remain the single entry point for all uploads.
Member
Author
Thanks, was looking for that :) |
When a file is not processed by vips (unsupported image formats, PDFs, videos, etc.), set generate_sub_sizes to true so the server generates thumbnails. Vips-supported images keep generate_sub_sizes as false since thumbnails are created client-side.
Member
Author
@swissspidy - Updated to avoid a separate queue, please review. |
swissspidy
approved these changes
Feb 17, 2026
andrewserong
approved these changes
Feb 18, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Not sure if it's the same bug as we saw elsewhere with the filenames, but when uploading non-image media, the filename of the file I'm uploading gets renamed (both as it exists on the server and in the block editor).
I.e I'd expect to see this after uploading a PDF:
But I actually see this (the type is used as the filename, and the file is unexpectedly document.pdf):
This appears to be happening on trunk, too, so not a blocker to landing this PR (just thought I'd mention it since I noticed while testing this PR, though).
As for this change, it's otherwise testing well for me! (Only the supported images are processed by vips, and the others appear to be passed through to the server 👍)
Member
Author
Noted. I'll work on this in a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #74566
Fixes #74357
Changes
CLIENT_SIDE_SUPPORTED_MIME_TYPESconstant defining formats vips can handle (JPEG, PNG, GIF, WebP, AVIF)canProcessWithVips()helper function to check file compatibilityHow It Works
When a user uploads files with client-side media processing enabled:
canProcessWithVips()based on MIME typeTest Plan
🤖 Generated with Claude Code